Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java-sdk): don't send tuple key on empty read request #229

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix(java-sdk): don't send tuple key on empty read request #229

merged 3 commits into from
Oct 31, 2023

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Oct 31, 2023 •
edited
Loading

Description

  • fix(client): don't send tuple key on empty read request
  • fix(client): remove unnecessary parameter from ClientExpandRequest
  • chore: bump version to 0.3.0

References

generates openfga/java-sdk#31
closes openfga/java-sdk#30

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@booniepepper booniepepper requested a review from a team as a code owner October 31, 2023 16:57
@booniepepper booniepepper marked this pull request as draft October 31, 2023 16:58
@booniepepper booniepepper marked this pull request as ready for review October 31, 2023 19:34
@booniepepper booniepepper mentioned this pull request Oct 31, 2023
Merged
4 tasks
@booniepepper booniepepper force-pushed the fix/java-client-empty-read branch from 0bbb602 to 7a890dd Compare October 31, 2023 21:45
@rhamzeh rhamzeh added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit ca2b7a3 Oct 31, 2023
6 checks passed
@rhamzeh rhamzeh deleted the fix/java-client-empty-read branch October 31, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to retrieve all tuples
2 participants
@booniepepper @rhamzeh