Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java-sdk): Adjust sdk-generator to be compatible with java-sdk #470

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

piotrooo
Copy link
Contributor

@piotrooo piotrooo commented Jan 20, 2025

Description

I started working on openfga/java-sdk#127, but I realized that the java-sdk repo contains manually changed files not generated through the sdk-generator. This leads me to first align the code between the sdk-generator and the java-sdk.

Tip

I also believe that to prevent such modifications, all *-sdk repos should be set to read-only mode. As outlined in the contribution guides, all changes should be made thought the sdk-generator. As a very fist step, a GitHub Workflow could be introduced to manually generate SDKs.

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@piotrooo piotrooo requested a review from a team as a code owner January 20, 2025 10:15
Copy link

linux-foundation-easycla bot commented Jan 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@piotrooo piotrooo changed the title [featAdjust sdk-generator to be compatible with java-sdk feat: Adjust sdk-generator to be compatible with java-sdk Jan 20, 2025
@piotrooo piotrooo changed the title feat: Adjust sdk-generator to be compatible with java-sdk feat(java-sdk): Adjust sdk-generator to be compatible with java-sdk Jan 20, 2025
@piotrooo
Copy link
Contributor Author

@rhamzeh can we merge this and go to java-sdk and generate code?

@rhamzeh
Copy link
Member

rhamzeh commented Jan 21, 2025

Yes! Thanks for your PR and putting this effort @piotrooo!

@rhamzeh rhamzeh added this pull request to the merge queue Jan 21, 2025
Merged via the queue into openfga:main with commit bf4cbed Jan 21, 2025
11 checks passed
@piotrooo piotrooo deleted the housekeeping/adjust-java-sdk branch January 21, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants