Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(entities): fix doctests #1255

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

bonjourmauko
Copy link
Member

Fixes #1254
Depends on #1253
Supersedes #1034

New features

  • Make CoreEntity public
    • Allows for more easily creating customised entities.

Technical changes

  • Add missing doctests.

@bonjourmauko bonjourmauko added the kind:docs Add or improvement of documentation label Oct 1, 2024
@bonjourmauko bonjourmauko added this to the Improved testing milestone Oct 1, 2024
@bonjourmauko bonjourmauko self-assigned this Oct 1, 2024
@bonjourmauko bonjourmauko requested review from a team October 1, 2024 02:33
@coveralls
Copy link

coveralls commented Oct 1, 2024

Coverage Status

coverage: 82.263% (+0.006%) from 82.257%
when pulling 233df9e on test/fix-entities-doctests
into 66d0052 on master.

@bonjourmauko bonjourmauko force-pushed the docs/fix-entities-docs branch from 884ce02 to d94bf4d Compare October 1, 2024 12:00
Base automatically changed from docs/fix-entities-docs to master October 1, 2024 12:10
@bonjourmauko bonjourmauko added kind:test Adding missing tests or correcting existing tests and removed kind:docs Add or improvement of documentation labels Oct 1, 2024
@bonjourmauko bonjourmauko force-pushed the test/fix-entities-doctests branch 3 times, most recently from ae86377 to 86d5447 Compare October 10, 2024 22:11
@bonjourmauko bonjourmauko changed the base branch from master to fix-mypy-checks-enums October 10, 2024 22:12
@bonjourmauko bonjourmauko force-pushed the fix-mypy-checks-enums branch 7 times, most recently from 0ca8e75 to 9b7d9c9 Compare October 14, 2024 11:33
Base automatically changed from fix-mypy-checks-enums to master October 14, 2024 11:38
@bonjourmauko bonjourmauko force-pushed the test/fix-entities-doctests branch from 86d5447 to 233df9e Compare October 14, 2024 11:42
@bonjourmauko
Copy link
Member Author

Poke @benjello @benoit-cty

@bonjourmauko bonjourmauko merged commit 7e219c3 into master Oct 14, 2024
29 checks passed
@bonjourmauko bonjourmauko deleted the test/fix-entities-doctests branch October 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:test Adding missing tests or correcting existing tests
Projects
Development

Successfully merging this pull request may close these issues.

Fix entities doctests
3 participants