Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capitalize country names. #504

Closed

Conversation

Sudhanva-Nadiger
Copy link
Contributor

What

  • Country names were in small letters
  • Now the first letter has been capitalized

Fixes bug(s)

Part of

@alexfauquette
Copy link
Member

ids can not be overridden. It's the key used to communicate with servers. Same for countryNames. We need the 'en:....' to know what is the standard name of the country

The trick is to distinguish e value and the displayed text: #386 (comment)

@Sudhanva-Nadiger
Copy link
Contributor Author

ohh yeah yeah got it!!! Like this ?
image
but if we type anything not in the list it shows no options noe

@alexfauquette
Copy link
Member

but if we type anything not in the list it shows no options noe

I don't get your point. If you update the PR, I could have a look to the behavior

@Sudhanva-Nadiger
Copy link
Contributor Author

image

This is what i was asking ! in the previous comment. If we type anything which is not in country names it shows no options !

@alexfauquette
Copy link
Member

Make sense that it does not show options if it's not part of the options. We put countries of the first countries concerned by eco-score. But you can use countries.json to get all the countries with product in OFF

@Sudhanva-Nadiger
Copy link
Contributor Author

Make sense that it does not show options if it's not part of the options. We put countries of the first countries concerned by eco-score. But you can use countries.json to get all the countries with product in OFF

Yeah, but we are currently using some of the country names, should we provide all countries as options in the card?

@Sudhanva-Nadiger
Copy link
Contributor Author

Hey I have opened a new pr, this window whitelisted file names giving me lots of trouble, so had to do lots of branch lol and send pr.

@Sudhanva-Nadiger Sudhanva-Nadiger deleted the new-temp branch February 1, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants