-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ContributionAssistant): new experiment, a contribution assistant using gemini #1025
Conversation
contain | ||
/> | ||
<v-card-text> | ||
<ProductInputRow :productForm="productPriceForm" :disableInitWhenSwitchingModes="true" @filled="productFormFilled = $event" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the mode init could be done beforehand ?
asking if its a photo of barcodes, or categories ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this one, barcode detection does not give great results with genai, so I wonder if it's something that should be even part of the process.
Thus, I don't mind keeping it a bit hidden for now, and leaving it the way it is for pictures containing both categories and barcodes. For example, I see a lot of stores selling loose apples and 4-pack apples side by side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
genai ftw!
approving so that we can merge quickly (when the backend is ready)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a separate commit to add this new prop: 3ece9a0
(so you'll need to rebase before merging 😅 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I did it ? Without creating too much of a mess ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah i guess there were some merge conflicts to resolve, sorry...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we'll be ready to merge I don't mind doing the last rebase to cleanup (the translations for instance)
…hen switching mode
…stant using gemini
… custom component
…enfoodfacts/open-prices-frontend into ttalex/contribution-assistant
did a few small changes here : a2ae48d
|
My idea behind not redirecting users after price addition was to let them add another proof without having to select the date and store again, by going back to the previous step. I believe it might be better to have a new tab that confirms the successful addition of prices and suggest a next step with links, either to the user dashboard or to go back to the proof page (and maybe clear the image ?) |
ah sorry, feel free to revert/edit the "redirect" change 🙇 |
What
Added features compared to the source:
Demo video / tutorial
demo_contribution_assistant.mp4
Requires backend update