Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ContributionAssistant): new experiment, a contribution assistant using gemini #1025

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

TTalex
Copy link
Collaborator

@TTalex TTalex commented Nov 9, 2024

What

Added features compared to the source:

  • Integration with Open Prices components
  • Added barcode detection, users can freely choose between modes (category vs barcode)
    • This makes it a bit more versatile, and no longer limited to fruits and vegetables only if barcodes are visible
  • Fixed display on small devices
  • Cropping now also works on mobile, but the UX is still pretty awful, so mouse/keyboard is still recommended
  • Removed login step, since it can use the global one
  • All prices are added under a single proof, containing the full image, instead of many cropped proofs

Demo video / tutorial

demo_contribution_assistant.mp4

Requires backend update

@teolemon teolemon added the GenAI label Nov 10, 2024
contain
/>
<v-card-text>
<ProductInputRow :productForm="productPriceForm" :disableInitWhenSwitchingModes="true" @filled="productFormFilled = $event" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the mode init could be done beforehand ?
asking if its a photo of barcodes, or categories ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this one, barcode detection does not give great results with genai, so I wonder if it's something that should be even part of the process.

Thus, I don't mind keeping it a bit hidden for now, and leaving it the way it is for pictures containing both categories and barcodes. For example, I see a lot of stores selling loose apples and 4-pack apples side by side.

Copy link
Member

@raphodn raphodn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genai ftw!
approving so that we can merge quickly (when the backend is ready)

Copy link
Member

@raphodn raphodn Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a separate commit to add this new prop: 3ece9a0
(so you'll need to rebase before merging 😅 )

Copy link
Collaborator Author

@TTalex TTalex Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did it ? Without creating too much of a mess ?

Copy link
Member

@raphodn raphodn Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah i guess there were some merge conflicts to resolve, sorry...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we'll be ready to merge I don't mind doing the last rebase to cleanup (the translations for instance)

@raphodn raphodn merged commit cdeec76 into master Nov 13, 2024
5 of 6 checks passed
@raphodn raphodn deleted the ttalex/contribution-assistant branch November 13, 2024 14:15
raphodn added a commit that referenced this pull request Nov 13, 2024
@raphodn
Copy link
Member

raphodn commented Nov 13, 2024

did a few small changes here : a2ae48d

  • new icon
  • spacing, button color, some existing translations, wider labels
  • redirect to dashboard at the end (like other price addition forms)

@TTalex
Copy link
Collaborator Author

TTalex commented Nov 13, 2024

My idea behind not redirecting users after price addition was to let them add another proof without having to select the date and store again, by going back to the previous step.

I believe it might be better to have a new tab that confirms the successful addition of prices and suggest a next step with links, either to the user dashboard or to go back to the proof page (and maybe clear the image ?)

@raphodn
Copy link
Member

raphodn commented Nov 13, 2024

ah sorry, feel free to revert/edit the "redirect" change 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants