Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup Compose for the project #5052

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

nishkarsh800
Copy link
Contributor

@nishkarsh800 nishkarsh800 commented Jul 29, 2023

Description

  • Setting up the current project structure to compose, so that we can migrate UI's upon that structure

Related issues

#5035

Related PRs

Screenshots

Link to the automatically generated build APK

@nishkarsh800 nishkarsh800 requested a review from a team as a code owner July 29, 2023 12:52
@nishkarsh800
Copy link
Contributor Author

@VaiTon Do I also need to integrate more compose dependencies for tasks like test impl or other stuffs?

Comment on lines 1 to 15
/*
* Copyright 2016-2020 Open Food Facts
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is auto generated. Should I keep this ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

app/build.gradle.kts Outdated Show resolved Hide resolved
gradle/libs.versions.toml Show resolved Hide resolved
@nishkarsh800 nishkarsh800 changed the title Setup Compose for the project (Work in Progress) Setup Compose for the project Jul 30, 2023
@nishkarsh800
Copy link
Contributor Author

@VaiTon Check the latest commit. Build is generated successfully.

@nishkarsh800
Copy link
Contributor Author

@VaiTon Kindly review my PR

@VaiTon
Copy link
Member

VaiTon commented Aug 1, 2023

I'll test this when I have time and then I'll merge this. Thank you for your work!

Also please put back the copyright header, and thanks!

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@VaiTon VaiTon changed the title Setup Compose for the project chore: setup Compose for the project Aug 2, 2023
@VaiTon VaiTon merged commit 428d3d0 into openfoodfacts:develop Aug 2, 2023
10 of 12 checks passed
@nishkarsh800 nishkarsh800 deleted the nish-compose-setup branch August 2, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants