Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Android 34 #5260

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Jul 31, 2024

Hi everyone,

This is the only upgrade we can do in the app without breaking anything.
Android API 35 will be released in a few weeks (but APIs are already stable) and it will require Gradle 8.
However, Green Dao is not maintained since 2020 and needs Gradle 7.

So unless we rewrite a lot of code, we can't do more than that.

@g123k g123k requested a review from a team as a code owner July 31, 2024 23:09
@g123k g123k self-assigned this Jul 31, 2024
@g123k
Copy link
Contributor Author

g123k commented Jul 31, 2024

@teolemon
Copy link
Member

teolemon commented Aug 1, 2024

fixed @g123k

Copy link

sonarcloud bot commented Aug 1, 2024

@teolemon
Copy link
Member

teolemon commented Aug 1, 2024

ProductCompareViewModelTest > addProductToCompare_shouldEmitAlreadyExistEvent_whenTheSameProductAdded() FAILED
com.google.common.truth.ComparisonFailureWithFacts at ProductCompareViewModelTest.kt:70

ProductCompareViewModelTest > addProductToCompare_shouldTrackRightAnalytics_whenProductsAddedToCompare() FAILED
java.lang.AssertionError at ProductCompareViewModelTest.kt:144

ProductCompareViewModelTest > onInit_productsAreEmpty() PASSED

ProductCompareViewModelTest > addProductToCompare_shouldAddProducts_whenProductsAreDifferent() FAILED
com.google.common.truth.ComparisonFailureWithFacts at ProductCompareViewModelTest.kt:99

ProductEditNutritionFactsFragmentTest > nutritionDefaultValuesTest() PASSED

ContributorsFragmentTest > test incomplete states() PASSED
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended

ProductPhotosViewModelTest > Given product api returns product images > When imageNames is called > it should return image names sorted by uploaded time() FAILED
kotlinx.coroutines.test.UncaughtExceptionsBeforeTest at ProductPhotosViewModelTest.kt:78

@teolemon teolemon merged commit ac820e4 into openfoodfacts:develop Aug 1, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update your target API level by August 31, 2024 to release updates to your app
2 participants