Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Update food_ingredients taxonomy #10814

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

openfoodfacts-bot
Copy link
Contributor

@openfoodfacts-bot openfoodfacts-bot commented Sep 20, 2024

What

This is a pull request automatically created using the Taxonomy Editor.

Description

This is a round trip in taxonomy editor to normalize parent name and merge duplicates entries.

This should then enable using taxonomy editor for real PR's on ingredients.

Link to the project in Taxonomy Editor

https://ui.taxonomy.openfoodfacts.org/food_ingredients/chore_ingredients_normalization

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients labels Sep 20, 2024
fr: huile de palme et de palmiste, huile de palme ou de palmiste, huile de palme ou huile de palmiste, palme ou palmiste
hr: palma i ulje palminih koštica, palmino ulje ili ulje palminih koštica
hu: pálma- és pálmamagolaj, pálmaolaj és pálmamagolaj, pálma- vagy pálmamagolaj, pálmaolaj vagy pálmamagolaj
nl: palmolie en palmkernolie, palmolie of palmkernolie
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleene @stephanegigandet
Taxonomy editor merge those, because product opener will merge them, as "and" and "or" are stopwords.

Is it ok to keep it like this ?

@@ -39987,27 +39911,19 @@ wikidata:en: Q2461726
# 132 products in 4 languages @2018-09-28

< en:pear juice
en: pear juice concentrate
en: pear juice concentrate, pear juice from concentrate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the same thing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a stopword problem again.

As there is no pear-juice-concentrate products, I propose to just remove this, and kip pear juice from concentrate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are not the same for the calculation of the Nutri-Score right?

DO CONCENTRATED JUICES COUNT WHEN WORKING OUT “FRUIT, VEGETABLE, PULSES, NUTS, AND RAPESEED, WALNUT AND OLIVE OILS” CONTENT? With regards to concentrated fruits and vegetables: Can be counted: fruit juices made from 100% concentrates E.g. orange juice made from 100% concentrate that is rehydrated to 100% (or coconut juice when rehydration results in 100% juice) Cannot be counted: concentrated fruit juices or fruit puree that have not been rehydrated to 100% E.g. juice/concentrated lemon syrup used in a sorbet cannot be counted as fruit
It's in the NUTRI-SCORE FREQUENTLY ASKED QUESTIONS https://www.royalkoopmans.com/uploads/fckconnector/284da573-50d7-50a8-8eb4-1a51a9a4f84b

Copy link

sonarcloud bot commented Sep 20, 2024

@alexgarel alexgarel marked this pull request as draft September 20, 2024 15:53
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🥗 Ingredients 💥 Merge Conflicts 💥 Merge Conflicts 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants