-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handling synonyms and text fields more efficiently #234
Conversation
- put main language handling in openfoodfacts.py - generate mappings - change indexing not tested yet + query is yet untouched
and fix a bug in logging during import
- return errors if query is not valid - understand open ranges
app/indexing.py
Outdated
number_of_fields, | ||
) | ||
|
||
log = logging.getLogger(__name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We name the logger logger
in the rest of the project, and use app.utils.get_logger
function (to set-up the right LOG_LEVEL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this because the logging.getLogger is very strange… if you give it a name, it resets log level to NOT_SET !
Here it wasn't used anymore so I removed it.
I will do a refactor on that, some time ;-)
Co-authored-by: Raphaël Bournhonesque <[email protected]>
Great work! 🎉 |
Part of: #193
@raphael0202 revealed some pending issues:
It might be a change in analyzer and/or synonyms file.
Apart from adding new test in test_search.py, I need to add a test on ES analysis, as it will help document behaviour.