Move images out of webpack #13118
Open
Move images out of webpack #13118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Webpacker still needs to know about them in order to build links.
png sprites? That was a flashback..
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dacook
force-pushed
the
10298-move-images-out-of-webpacker
branch
from
3c17296 to
4ee35fc
Compare
dacook
added
technical changes only
mkllnk
requested changes
Feb 4, 2025
| = render partial: 'spree/admin/shared/configuration_menu' | ||
| dmin= render partial: 'spree/admin/shared/configuration_menu' |
There was a problem hiding this comment.
😱
And the specs didn't cover it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
As Maikel suggested:
I think we shouldn't need images to be loaded by webpack. This will simplify the transition away from webpack.
I also tried to move the fonts but got stuck.
I have to confess I don't think I fully understood how it all hooks together, but it seems to be working!
What should we test?
This reverts some of #7784
So similar to that, test that images load, on some shop and admin screens.
I've checked this on au_staging.