Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly tests #142

Merged
merged 27 commits into from
Oct 18, 2024
Merged

Fix nightly tests #142

merged 27 commits into from
Oct 18, 2024

Conversation

lilyminium
Copy link
Collaborator

@lilyminium lilyminium commented Oct 13, 2024

This PR contains attempts to fix #120 (nightly CI)

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.36%. Comparing base (eac87f6) to head (4a9a626).
Report is 1 commits behind head on main.

Additional details and impacted files

@lilyminium
Copy link
Collaborator Author

lilyminium commented Oct 14, 2024

Ah, the issue is within the DGL install itself -- even skipping any pytorch installations still triggers the graphbolt error.

Edit: may have something to do with DGL stopping providing new nightly windows and Mac versions at the URL being used? We may have to build from source.

@lilyminium lilyminium changed the title Install pytorch before dgl? Fix nightly tests Oct 17, 2024
@lilyminium
Copy link
Collaborator Author

Building DGL from source on Ubuntu seems to consistently fail with Python 3.10.

@lilyminium lilyminium marked this pull request as ready for review October 18, 2024 07:12
@lilyminium
Copy link
Collaborator Author

Ok, this fixes dev CI (run manually) and also some actual code.

@lilyminium lilyminium merged commit 12844b9 into main Oct 18, 2024
7 checks passed
@lilyminium lilyminium deleted the fix-nightly-ci branch October 18, 2024 07:13
@lilyminium lilyminium mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants