Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix normalization #149

Merged
merged 12 commits into from
Oct 21, 2024
Merged

Fix normalization #149

merged 12 commits into from
Oct 21, 2024

Conversation

lilyminium
Copy link
Collaborator

@lilyminium lilyminium commented Oct 18, 2024 •
edited
Loading

Fixes #119

Changes made in this Pull Request:

  • Fixed normalization issues
  • Bent over backwards to make tests work around the Toolkit's automatic sanitisation of RDKit molecules

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (1d7e4ff) to head (c562080).
Report is 5 commits behind head on main.

Additional details and impacted files

@lilyminium
Copy link
Collaborator Author

Failing tests are due to #152.

@lilyminium lilyminium merged commit 6aef0ed into main Oct 21, 2024
1 check passed
@lilyminium lilyminium deleted the fix-normalization branch October 21, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with normalizing molecules
2 participants
@lilyminium @codecov-commenter