Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/fix docs builds #176

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Update/fix docs builds #176

merged 1 commit into from
Jan 21, 2025

Conversation

mattwthompson
Copy link
Member

There was a small cross-interaction between #168 and #172 which didn't show up until they were in the same branch. It seems that python.install.method: setuptools internally calls python seutp.py but python.install.method: pip calls pip install -e ..

https://docs.readthedocs.io/en/stable/config-file/v2.html#packages

I tested this with ace4ee9 in #175 and it works but don't want to just sneak it in to a separate PR. I still intend to merge this without review since it's scoped to already-approved changes.

Changes made in this Pull Request:

  • Fix RTD config to use pip install instead of python setup.py

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@mattwthompson
Copy link
Member Author

Docs appear to be building fine: https://readthedocs.org/projects/openff-nagl/builds/26919217/

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (ae50e54) to head (5c134e2).
Report is 1 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review January 21, 2025 12:01
@mattwthompson mattwthompson merged commit c2f8863 into main Jan 21, 2025
134 checks passed
@mattwthompson mattwthompson deleted the fix-172 branch January 21, 2025 12:06
@mattwthompson mattwthompson mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants