Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try always using markup: markdown #500

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Try always using markup: markdown #500

merged 2 commits into from
Jan 29, 2025

Conversation

mattwthompson
Copy link
Member

Similar to #499 but more straightforward

I'm not sure what markup: mark was ever meant to do but it's the cause of many cryptic errors associated with upgrading Hugo

@mattwthompson mattwthompson mentioned this pull request Jan 6, 2025
@mattwthompson
Copy link
Member Author

mattwthompson commented Jan 6, 2025

The action doesn't seem to host the build page, but locally I'm seeing it build without (build-time) error

$ hugo server -D                                                                                15:30:42  ☁  markup-markdown ☀
Watching for changes in /Users/mattthompson/software/openforcefield.org/{archetypes,content,data,static,themes}
Watching for config changes in /Users/mattthompson/software/openforcefield.org/config.toml
Start building sites …
hugo v0.140.2+extended+withdeploy darwin/amd64 BuildDate=2024-12-30T15:01:53Z VendorInfo=brew


                   | EN
-------------------+------
  Pages            | 607
  Paginator pages  |  64
  Non-page files   | 321
  Static files     |  38
  Processed images |   0
  Aliases          | 231
  Cleaned          |   0

Built in 14892 ms
Environment: "development"
Serving pages from disk
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at http://localhost:1313/ (bind address 127.0.0.1)
Press Ctrl+C to stop

Though something's funky with the linebreaks?

image

@mattwthompson mattwthompson marked this pull request as draft January 6, 2025 21:35
@mattwthompson mattwthompson marked this pull request as ready for review January 23, 2025 21:36
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for digging into this @mattwthompson. The weird formatting for previous blog posts is worth it to get the build system more up to date. People writing new blog posts will get to see the weird layout in their local rendering and can figure out how to work around it.

@j-wags j-wags merged commit 4a9f843 into v2 Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants