Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iodine frag opt #373

Merged
merged 14 commits into from
Sep 12, 2024
Merged

Iodine frag opt #373

merged 14 commits into from
Sep 12, 2024

Conversation

amcisaac
Copy link
Collaborator

@amcisaac amcisaac commented Sep 10, 2024

New Submission Checklist

  • Created a new folder in the submissions directory containing the dataset
  • Added README.md describing the dataset see here for examples
  • All files used to produce the dataset are included with a description
  • Dataset follows the QCSubmit schema defined for Datasets, OptimizationDatasets and TorsionDriveDatasets
  • Dataset filename matches pattern dataset*.json; may feature a compression extension, such as .bz2
  • A PDF depicting the molecules is attached, in the case of torsiondrives this should include the highlighting of the central bond, this can be done automatically using qcsubmit.
  • QCSubmit validation passed
  • Made a new dataset entry in the mapping table in repository README.md
  • Ready to submit!

Compute Expansion Checklist

  • Compute expansion filename matches pattern compute*.json; may feature a compression extension, such as .bz2
  • QCSubmit validation passed
  • Ready to submit!

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements C ,O ,I ,S ,F ,Br ,Cl ,N ,H
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/HF/6-31G*
Specification Name HF/6-31G*
Method hf
Basis 6-31G*
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements C ,O ,I ,S ,F ,Br ,Cl ,N ,H
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/HF/6-31G*
Specification Name HF/6-31G*
Method hf
Basis 6-31G*
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements O ,C ,Cl ,I ,H ,N ,F ,Br ,S
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements O ,C ,Cl ,I ,H ,N ,F ,Br ,S
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

1 similar comment
@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements O ,C ,Cl ,I ,H ,N ,F ,Br ,S
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@amcisaac amcisaac requested a review from lilyminium September 10, 2024 22:45
Copy link
Contributor

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amcisaac, largely looks good -- just a couple minor comments!

Non-blocking, but for the full environment, it might be helpful to also add conda env export > full-environment-file.yaml -- this gives largely the same information, albeit without channel information, but in the format of a file you can then (if you're on an identical architecture and with some luck) use to re-create the environment with conda env create.

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements O ,C ,Cl ,I ,H ,N ,F ,Br ,S
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

3 similar comments
@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements O ,C ,Cl ,I ,H ,N ,F ,Br ,S
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements O ,C ,Cl ,I ,H ,N ,F ,Br ,S
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements O ,C ,Cl ,I ,H ,N ,F ,Br ,S
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@lilyminium
Copy link
Contributor

Thanks @amcisaac! Could you please update the description of the enamine datasets in the OptimizationDataset itself as well, please? Otherwise looks good to go!

@amcisaac amcisaac requested a review from lilyminium September 10, 2024 23:30
@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements S ,C ,N ,F ,I ,Cl ,H ,O ,Br
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@lilyminium
Copy link
Contributor

I think #375 or #377 should get this going.

@amcisaac
Copy link
Collaborator Author

Thanks so much for looking into that!

@lilyminium
Copy link
Contributor

FYI @amcisaac you might want to check you have git lfs installed -- I got the following message when I checked out your branch just then. I took the liberty of pushing the pointer migration just to get things running :-)

Encountered 1 file that should have been a pointer, but wasn't:
	submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2
Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type OptimizationDataset
Elements S ,C ,N ,F ,I ,Cl ,H ,O ,Br
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-09-10-OpenFF-Iodine-Fragment-Opt-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.4
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@lilyminium lilyminium merged commit 07247d2 into master Sep 12, 2024
1 check passed
@lilyminium lilyminium deleted the iodine-frag-opt branch September 12, 2024 13:46
@openff-dangerbot
Copy link
Contributor

Lifecycle - QCSubmit Submission Report : SUCCESS

Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type optimization
UTC Datetime 2024-09-12 13:47 UTC

Response from public QCArchive:

None

QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.3
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

@lilyminium
Copy link
Contributor

lilyminium commented Sep 12, 2024

Whoops, the bot message reads a little more ominously from "dangerbot". (The current title format of bot comments is "Current status -- {column_where_card_should_be}". Unfortunately we have to move it ourselves manually for the time being. Just moved to Error Cycling)

@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

@openff-dangerbot
Copy link
Contributor

Lifecycle - Error Cycling Report

Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type optimization
UTC Datetime 2024-09-12 16:07 UTC

All errored tasks will be restarted.
Errored states prior to restart reported below.

OptimizationRecord current status

specification COMPLETE RUNNING WAITING ERROR CANCELLED INVALID DELETED
default 147 38 346 0 0 0 0

OptimizationRecord Error Tracebacks:

Tracebacks (click to expand)


QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.3
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

@amcisaac
Copy link
Collaborator Author

@lilyminium thank you for fixing that! I thought it was installed but looks like you're right it wasn't...weird that it didn't give me any errors when I added the file. I've installed it now so hopefully shouldn't happen again.

@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

3 similar comments
@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

@openff-dangerbot
Copy link
Contributor

Lifecycle - Error Cycling Report

Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type optimization
UTC Datetime 2024-09-13 12:04 UTC

All errored tasks will be restarted.
Errored states prior to restart reported below.

OptimizationRecord current status

specification COMPLETE RUNNING WAITING ERROR CANCELLED INVALID DELETED
default 529 2 0 0 0 0 0

OptimizationRecord Error Tracebacks:

Tracebacks (click to expand)


QCSubmit version information(click to expand)
version
openff.qcsubmit 0.53.0
openff.toolkit 0.16.3
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.03.5

@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

2 similar comments
@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

@openff-dangerbot
Copy link
Contributor

Current status - Error Cycling

Consider manually moving this.

@openff-dangerbot
Copy link
Contributor

Current status - Archived/Complete

Consider manually moving this.

@openff-dangerbot
Copy link
Contributor

Lifecycle - Archived/Complete

Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type optimization
UTC Datetime 2024-09-14 00:34 UTC

Dataset Complete!

@openff-dangerbot
Copy link
Contributor

Current status - Archived/Complete

Consider manually moving this.

@openff-dangerbot
Copy link
Contributor

Lifecycle - Archived/Complete

Dataset Name OpenFF Iodine Fragment Opt v1.0
Dataset Type optimization
UTC Datetime 2024-09-14 04:08 UTC

Dataset Complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants