Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy to clipboard #478

Merged
merged 1 commit into from
Aug 28, 2023
Merged

copy to clipboard #478

merged 1 commit into from
Aug 28, 2023

Conversation

ramirobg94
Copy link
Contributor

No description provided.

@@ -26,6 +26,10 @@ const OpenInMap = ({nodeDef}) => {
});
};

if (!nodes[0]?.value?.x || !nodes[0]?.value?.y) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if x or y is 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, but extremely weird! if you are there the waves are going to move you and the error is going to show some location,
https://www.google.com/maps/place/0%C2%B000'00.0%22N+0%C2%B000'00.0%22E

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

13.3% 13.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ramirobg94 ramirobg94 merged commit f4bfb49 into master Aug 28, 2023
2 of 3 checks passed
@ramirobg94 ramirobg94 deleted the copy-to-clipboard branch August 28, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants