FLEX-106: 🔀 Merge v2.20.1 into OPEN's customized version of SEED

.dockerignore

@@ -15,4 +15,3 @@ node_modules
 vendors/node_modules
 config/settings/local_untracked.py
 config/settings/local_untracked.py.dist
-oep

.editorconfig

@@ -6,7 +6,7 @@ charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
-[*.{js,json}]
+[*.{html,js,json}]
 indent_size = 2
 
 [*.py]

.eslintrc.js

@@ -0,0 +1,101 @@
+module.exports = {
+  extends: 'airbnb-base',
+  parserOptions: {
+    ecmaVersion: 2022
+  },
+  env: {
+    browser: true,
+    es6: true,
+    jasmine: true,
+    jquery: true
+  },
+  globals: {
+    _: true,
+    $filter: true,
+    $route: true,
+    angular: true,
+    angularDragula: true,
+    BE: true,
+    Chart: true,
+    dimple: true,
+    inject: true,
+    module: true,
+    moment: true,
+    ol: true,
+    pluralize: true,
+    protractor: true,
+    qq: true,
+    saveAs: true,
+    Spinner: true,
+    Terraformer: true,
+    UniqueBuildingIdentification: true
+  },
+  plugins: [
+    'angular',
+    'prefer-arrow',
+    'protractor'
+  ],
+  rules: {
+    'arrow-parens': [
+      'error',
+      'always'
+    ],
+    'comma-dangle': [
+      'error',
+      'never'
+    ],
+    'consistent-return': 'warn',
+    'func-style': [
+      'error',
+      'declaration',
+      {
+        allowArrowFunctions: true
+      }
+    ],
+    'linebreak-style': 'off',
+    'max-len': [
+      'warn',
+      200,
+      2,
+      {
+        ignoreUrls: true,
+        ignoreComments: true,
+        ignoreRegExpLiterals: true,
+        ignoreStrings: true,
+        ignoreTemplateLiterals: true
+      }
+    ],
+    'no-plusplus': 'off',
+    'no-restricted-syntax': [
+      'error',
+      'ForInStatement',
+      'LabeledStatement',
+      'WithStatement'
+    ],
+    'no-sequences': 'error',
+    'no-shadow': 'warn',
+    'object-shorthand': [
+      'error',
+      'properties'
+    ],
+    'operator-linebreak': [
+      'error',
+      'after'
+    ],
+    'prefer-arrow/prefer-arrow-functions': [
+      'error',
+      {
+        disallowPrototype: true,
+        singleReturnOnly: true,
+        classPropertiesAllowed: false
+      }
+    ],
+    // FIX LATER
+    camelcase: 'off',
+    'default-case': 'off',
+    'no-console': 'off',
+    'no-param-reassign': 'off',
+    'no-underscore-dangle': 'off',
+    'prefer-destructuring': 'off'
+  }
+};

.github/CONTRIBUTING.md

@@ -13,7 +13,7 @@ The contribution process for SEED is composed of three steps:
 1.  Send consent email
 
     In order for us to distribute your code as part of SEED under the SEED
-    [license](https://github.com/SEED-platform/seed/blob/main/LICENSE), we’ll need
+    [license](https://github.com/SEED-platform/seed/blob/main/LICENSE.md), we’ll need
     your consent. An email acknowledging understanding of these terms and agreeing to them is
     all that will be asked of any contributor. Send an email to the SEED project manager (see
     below for the address) including the following text and a list of co-contributors (if any):

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,9 +1,9 @@
 ---
 name: Bug report
 about: Create a report to help improve SEED
-title: ""
-labels: "Bug"
-assignees: ""
+title: ''
+labels: 'Bug'
+assignees: ''
 ---
 
 <!--Fill in the following information detailing the issue. Make sure to not disclose protected data (e.g., passwords). Screenshots are helpful.-->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,9 +1,9 @@
 ---
 name: Feature request
 about: Suggest an idea or improvement for SEED
-title: ""
+title: ''
 labels: Feature
-assignees: ""
+assignees: ''
 ---
 
 **Is your feature request related to a problem? Please describe.**

.github/workflows/ci.yml

@@ -58,19 +58,27 @@ jobs:
           npm install
           sudo apt update
           sudo apt install -y xvfb
-          wget --no-verbose -O /tmp/chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
-          sudo apt install -y /tmp/chrome.deb
+          # Available chrome-driver versions: https://chromedriver.storage.googleapis.com/
+          # Available google-chrome versions: https://www.ubuntuupdates.org/package/google_chrome/stable/main/base/google-chrome-stable?id=202706
+          # Lock to 114.0.5735.90
+          wget --no-verbose -O /tmp/chrome.deb https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
+          sudo apt install -y --allow-downgrades /tmp/chrome.deb
           google-chrome --version
       - name: Test Django
         if: ${{ matrix.test_env == 'django' }}
         env:
           SEED_PM_UN: ${{ secrets.SEED_PM_UN }}
           SEED_PM_PW: ${{ secrets.SEED_PM_PW }}
+          SF_INSTANCE: ${{ secrets.SF_INSTANCE }}
+          SF_USERNAME: ${{ secrets.SF_USERNAME }}
+          SF_PASSWORD: ${{ secrets.SF_PASSWORD }}
+          SF_DOMAIN: ${{ vars.SF_DOMAIN }}
+          SF_SECURITY_TOKEN: ${{ secrets.SF_SECURITY_TOKEN }}
           COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
           DJANGO_LOG_LEVEL: ERROR
         run: |
           docker exec seed_web touch /seed/config/settings/local_untracked.py
-          docker exec --env SEED_PM_UN --env SEED_PM_PW --env DJANGO_LOG_LEVEL seed_web coverage run manage.py test seed --settings=config.settings.docker_dev
+          docker exec --env SEED_PM_UN --env SEED_PM_PW --env DJANGO_LOG_LEVEL --env SF_INSTANCE --env SF_USERNAME --env SF_PASSWORD --env SF_SECURITY_TOKEN --env SF_DOMAIN seed_web coverage run manage.py test --settings=config.settings.docker_dev
           if [[ ! -z "${COVERALLS_REPO_TOKEN}" ]]; then
             docker exec --env COVERALLS_REPO_TOKEN seed_web coveralls
           else
@@ -83,9 +91,9 @@ jobs:
         run: |
           CHROME_VERSION=$(google-chrome --version | awk '{ print $NF }')
           echo "Getting webdriver for chrome version ${CHROME_VERSION}"
-          ./node_modules/protractor/bin/webdriver-manager update --versions.chrome=${CHROME_VERSION} --gecko=false
+          npx webdriver-manager update --versions.chrome=${CHROME_VERSION} --gecko=false
           Xvfb :99 &
-          ./node_modules/protractor/bin/protractor seed/static/seed/tests/protractor-tests/protractorConfig.js
+          npx protractor seed/static/seed/tests/protractor-tests/protractorConfig.js
       - name: Test API
         if: ${{ matrix.test_env == 'api' }}
         run: |

.gitignore

@@ -63,6 +63,7 @@ seed/data_importer/tests/data/tmp_*
 seed/data_importer/tests/data/~*
 seed/tests/api/api_test_user.json
 seed/building_sync/tests/data/test_file.xml
+seed/tests/output
 test.sqlite
 
 # Ignore all protractor coverage

.pre-commit-config.yaml

@@ -1,8 +1,3 @@
-exclude: |
-  (?x)(
-    .*/migrations
-  )
-
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.4.0
@@ -18,9 +13,12 @@ repos:
         exclude: .*/templates
       - id: debug-statements
       - id: end-of-file-fixer
+        exclude: seed/static/seed/locales/
       - id: mixed-line-ending
+        exclude: seed/static/seed/locales/
       - id: pretty-format-json
         args: ["--autofix", "--no-sort-keys", "--no-ensure-ascii"]
+        exclude: seed/static/seed/locales/
   - repo: https://github.com/pre-commit/mirrors-isort
     rev: v5.10.1
     hooks:

.prettierignore

@@ -1,4 +1,5 @@
 CHANGELOG.md
-seed/tests/data/vcr_cassettes/
 charts/persistentvolumes/templates/
 charts/seed/templates/
+seed/static/seed/locales/
+seed/tests/data/vcr_cassettes/

.prettierrc

@@ -0,0 +1,30 @@
+{
+  "singleQuote": true,
+  "overrides": [
+    {
+      "files": "*.html",
+      "options": {
+        "printWidth": 200
+      }
+    },
+    {
+      "files": "*.js",
+      "options": {
+        "printWidth": 200,
+        "trailingComma": "none"
+      }
+    },
+    {
+      "files": "*.scss",
+      "options": {
+        "printWidth": 200
+      }
+    },
+    {
+      "files": ["*.yaml", "*.yml"],
+      "options": {
+        "singleQuote": false
+      }
+    }
+  ]
+}

.stylelintrc.js

@@ -0,0 +1,26 @@
+module.exports = {
+  extends: 'stylelint-config-standard-scss',
+  rules: {
+    // Fix later
+    'no-descending-specificity': null,
+    'scss/dollar-variable-pattern': [
+      '^([a-z][a-z0-9]*)(-[a-z0-9]+)*|([a-z][a-z0-9]*)(_[a-z0-9]+)*$',
+      {
+        message: 'Expected variable to be kebab-case or snake_case'
+      }
+    ],
+    'scss/no-global-function-names': null,
+    'selector-class-pattern': [
+      '^([a-z][a-z0-9]*)(-[a-z0-9]+)*|([a-z][a-z0-9]*)(_[a-z0-9]+)*$',
+      {
+        message: 'Expected class selector to be kebab-case or snake_case'
+      }
+    ],
+    'selector-id-pattern': [
+      '^([a-z][a-z0-9]*)(-[a-z0-9]+)*|([a-z][a-z0-9]*)(_[a-z0-9]+)*$',
+      {
+        message: 'Expected id selector to be kebab-case or snake_case'
+      }
+    ]
+  }
+};