Rework pg_service.conf handling to support SSL keys authentication #5855
+56
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the way we handle the presence of a pg_service.conf in the QField data directory (i.e. on Android /Android/data/ch.opengis.qfield/files/QField) to allow for immediate and future improvements.
The big change: instead of having postgres consume that service configuration file (most often drag and dropped via USB cable), QField will copy its content into a new pg_service.conf file living within the QField app's writable system directory. By doing this, we unlock the ability by QField to modify that pg_service.conf file at will (think QFieldCloud-provided services being written into that file when successfully logging into QFC).
Back to the present, the new handling is meant to unlock support for SSL keys authentication through the following logic:
This method allows us to support SSL authentication on Android in a way that allows for the users to share the same pg_services.conf content across desktop and Android.