Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enable snapping to angle when cursor locked to position, improve code to avoid referencing to parent item #5893

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Dec 14, 2024

This PR fixes #5882

@suricactus , thanks for the report. I've also taken the opportunity to update the code to avoid referencing to the snapToCommonAngleButton item. That created an assumption it is always present in the parent scene, which makes it harder to test items in isolation afterwards.

@nirvn nirvn closed this Dec 15, 2024
@nirvn
Copy link
Member Author

nirvn commented Dec 15, 2024

,

@nirvn nirvn reopened this Dec 15, 2024
@qfield-fairy
Copy link
Collaborator

@nirvn nirvn merged commit ac4e945 into master Dec 17, 2024
36 of 49 checks passed
@nirvn nirvn deleted the snapping_cleanupo_fix branch December 17, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost line appears when both angle snapping is enabled and the coordinate cursor is locked
2 participants