Implement a iface function for plugins to add actions to the new dashboard actions toolbar #5953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…board actions toolbar
|
(Cleaning up as we're ending towards the end of this development cycle :) ) |
|
🎉 Ta-daaa, freshly created APKs are available for 2fbb936: arm64-android |
|
I spot a problem here: there is a bottom scrollbar if I am right. Can we avoid that? Or probably, can we remove some of the items from the topbar via a plugin? |
|
@suricactus , it's not a problem, it's a feature, see this: #5938 |
|
@suricactus , OK to merge as is for now? |
|
I am 9k if you are ok. I am afraid the scrollbar will be confusing and hard to manage from user perspective - attempts to scroll will become taps and people open instruments by accident. |
|
@suricactus , let's go for this now and adjust based on broader feedback from the overall redesign efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot time, look at the beautiful Ask AI button here:
As seen above, the PR allows for plugins to gently place themselves into the new dashboard actions toolbar. I've also resurrected the iface.addItemToMainMenuActionsToolbar() function as a deprecated method that now stands as an alias to addItemToDashboardActionsToolbar(). While plugins are still in their first year of existence, I guess it's not bad to avoid outright breaking things :)