-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump django-allauth to 65.3.1 #1084
Bump django-allauth to 65.3.1 #1084
Conversation
Task linked: QF-4844 Bump django-allauth to 64.2.1+ |
Actually, after having removed the
Still trying to figure out how to manage to re-enable login after to many failed attempts, switching this PR to WIP. Edit : am also trying to manage a way to notify and display the user in how many time he/she will be allowed to try again a login. I find this "try again later" not nice :( |
8d5da06
to
c072a45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still open TODOs in the PR? If they are no longer relevant, please strikethrough them and explain why they are no longer relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Please squash all in a single commit, do some tests and if all good, it is ready to merge!
Thanks for the review @suricactus !
Actually I have been testing, rate limiter looks fine but after a successful login, there is this error message : Seems related to the axes compat, maybe I would recommend to proceed like this :
What do you think ? Maybe next time we could also regroup dependencies bumping into a single PR ? |
Task linked: QF-4848 Bump django-axes to 6.0.0+ |
Hi, @gounux . You can always change the base of a PR to point not to master, but other specific branch. Hope this helps: This kind of PRs should ideally be one per dependency with very strict commits and messages related to tme, so they can be easily reverted when needed. |
068bc84
to
f697c20
Compare
ac71652
to
93e1935
Compare
This PR upgrades
django-allauth
dependency version to a newer one :django-allauth
to65.3.1
in requirementsallauth.account.middleware.AccountMiddleware
to settings'MIDDLEWARE
(see Quickstart guide)removes(edit : choice has been made to keep thedjango-axes
from the requirementsdjango-axes
rate limiter for the moment, since it provides a convenient way to re-enable a locked-out user, in the admin interface)authentication
module tests as well)