Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-allauth to 65.3.1 #1084

Merged

Conversation

gounux
Copy link
Contributor

@gounux gounux commented Dec 18, 2024

This PR upgrades django-allauth dependency version to a newer one :

  • bumps django-allauth to 65.3.1 in requirements
  • adds allauth.account.middleware.AccountMiddleware to settings' MIDDLEWARE (see Quickstart guide)
  • removes django-axes from the requirements (edit : choice has been made to keep the django-axes rate limiter for the moment, since it provides a convenient way to re-enable a locked-out user, in the admin interface)
  • does not add any regression (check authentication module tests as well)

@duke-nyuki
Copy link
Collaborator

Task linked: QF-4844 Bump django-allauth to 64.2.1+

@gounux
Copy link
Contributor Author

gounux commented Jan 8, 2025

Actually, after having removed the axes dependency, the allauth rate limiter makes an alert get displayed, directly in the login page :

image

allauth's rate limiter doc is here FYI.

Still trying to figure out how to manage to re-enable login after to many failed attempts, switching this PR to WIP.

Edit : am also trying to manage a way to notify and display the user in how many time he/she will be allowed to try again a login. I find this "try again later" not nice :(

@gounux gounux changed the title Bump django-allauth to 65.3.0 [WIP] Bump django-allauth to 65.3.0 Jan 8, 2025
@gounux gounux changed the title [WIP] Bump django-allauth to 65.3.0 [WIP] Bump django-allauth to 65.3.1 Jan 8, 2025
@gounux gounux force-pushed the QF-4844-bump-allauth-to-newer-version branch from 8d5da06 to c072a45 Compare January 9, 2025 07:59
@gounux gounux changed the title [WIP] Bump django-allauth to 65.3.1 Bump django-allauth to 65.3.1 Jan 9, 2025
@gounux gounux requested a review from suricactus January 9, 2025 08:00
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still open TODOs in the PR? If they are no longer relevant, please strikethrough them and explain why they are no longer relevant.

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Please squash all in a single commit, do some tests and if all good, it is ready to merge!

@gounux
Copy link
Contributor Author

gounux commented Jan 12, 2025

Thanks for the review @suricactus !

do some tests and if all good, it is ready to merge!

Actually I have been testing, rate limiter looks fine but after a successful login, there is this error message :

image

Seems related to the axes compat, maybe I would recommend to proceed like this :

What do you think ?

Maybe next time we could also regroup dependencies bumping into a single PR ?
My bad for this one actually, apologies for the noise

@suricactus suricactus changed the base branch from master to QF-4848-bump-axes-to-v6 January 13, 2025 09:47
@duke-nyuki
Copy link
Collaborator

Task linked: QF-4848 Bump django-axes to 6.0.0+

@suricactus
Copy link
Collaborator

Hi, @gounux . You can always change the base of a PR to point not to master, but other specific branch. Hope this helps:
image

This kind of PRs should ideally be one per dependency with very strict commits and messages related to tme, so they can be easily reverted when needed.

@opengisch opengisch deleted a comment from suricactus Jan 14, 2025
@gounux gounux force-pushed the QF-4844-bump-allauth-to-newer-version branch from 068bc84 to f697c20 Compare January 14, 2025 05:42
@gounux gounux force-pushed the QF-4844-bump-allauth-to-newer-version branch from ac71652 to 93e1935 Compare January 14, 2025 06:03
@gounux gounux merged commit 1df65b5 into QF-4848-bump-axes-to-v6 Jan 14, 2025
11 checks passed
@gounux gounux deleted the QF-4844-bump-allauth-to-newer-version branch January 14, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants