-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for Qt 6 builds #102
Conversation
(The test is failing because the new API from recent commits has not yet reached the docker image) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some things going on that I cannot completely grasp (not enough experience handling settings from QGIS), but in general it looks good to me. 👍🏽
I'll test in GUI and let you know if I find anything strange.
swiss_locator/core/settings.py
Outdated
class Settings(SettingManager): | ||
def __init__(self): | ||
SettingManager.__init__(self, pluginName) | ||
class Settings(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that object
is not necessary for Python 3. It was a Python 2 thing.
This one looks a bit better to me, but I guess there are pros and cons for both options. |
For reference, followup #92 |
Thanks a lot for the review. There's one scenario I'm a bit worried about raising to 3.40. Another point to take into account is how important it is to push new releases to 3.34:
|
let's bump to 3.40 and we can revert to 3.34 if needed later on! |
Yeah, good points. You know more about pros and cons with respect to the user base, let's hope it works with 3.40 as min and if not we need to be ready to revert as you said. 👍🏽 |
This makes the plugin compatible with Qt6 builds.
QGIS minimum version is raised to 3.34, the config dialogs is shown only for 3.40+.
Another approach would be to set the new minimum version to 3.40 (so we would leave the old version for 3.34-3.38), no strong opinion here.