Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for BOT_GITHUB_TOKEN secret #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Jan 2, 2024

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement
    I created this PR to fix the failing GitHub Actions.## Description
    This PR improves the error handling in the lock-issue GitHub Actions workflow. Previously, if the BOT_GITHUB_TOKEN secret was not set or invalid, the workflow would fail with a "Bad credentials" error. This error message was not very helpful in diagnosing the problem.

With the changes in this PR, the workflow now checks if the BOT_GITHUB_TOKEN secret is set before the dessant/lock-threads@v4 action is run. If the secret is not set, the workflow fails with a helpful error message.

Summary of Changes

  • Added a new step to the .github/workflows/lock-issue.yml workflow that checks if the BOT_GITHUB_TOKEN secret is set.
  • If the BOT_GITHUB_TOKEN secret is not set, the new step fails with a helpful error message.

@sweep-ai sweep-ai bot assigned cubxxw Jan 2, 2024
Copy link
Contributor Author

sweep-ai bot commented Jan 2, 2024

Rollback Files For Sweep

  • Rollback changes to .github/workflows/lock-issue.yml
  • Rollback changes to .github/workflows/lock-issue.yml

Copy link
Contributor Author

sweep-ai bot commented Jan 2, 2024

Sandbox Executions

  • Running GitHub Actions for .github/workflows/lock-issue.yml
Check .github/workflows/lock-issue.yml with contents:

Ran GitHub Actions for b9e0c989e6e2c69135d7f621e5f5af28f6f6f8eb:

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Jan 2, 2024
Copy link
Contributor Author

sweep-ai bot commented Jan 2, 2024

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run contributor-assistant/[email protected]
yielded the following error:
##[error]graphql call to get the committers details failed: HttpError: Bad credentials

Here are the logs:
CLA Assistant GitHub Action bot has started the process

Making changes according to plan... (step 3/3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant