-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347430: [CRaC] ContainerPidAdjustmentTest fails on WSL #179
Conversation
👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into |
@TimPushkin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rvansa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/contributor add tpushkin |
@TimPushkin |
/integrate |
@TimPushkin |
/sponsor |
Going to push as commit 45afd38. |
@rvansa @TimPushkin Pushed as commit 45afd38. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Makes
jdk/crac/ContainerPidAdjustmentTest.java
read/proc/sys/kernel/pid_max
instead of assuming it to always be 4194304Progress
Issue
Reviewers
Contributors
<[email protected]>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/179/head:pull/179
$ git checkout pull/179
Update a local copy of the PR:
$ git checkout pull/179
$ git pull https://git.openjdk.org/crac.git pull/179/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 179
View PR using the GUI difftool:
$ git pr show -t 179
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/179.diff
Using Webrev
Link to Webrev Comment