Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347430: [CRaC] ContainerPidAdjustmentTest fails on WSL #179

Closed
wants to merge 1 commit into from

Conversation

TimPushkin
Copy link
Collaborator

@TimPushkin TimPushkin commented Jan 10, 2025

Makes jdk/crac/ContainerPidAdjustmentTest.java read /proc/sys/kernel/pid_max instead of assuming it to always be 4194304


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8347430: [CRaC] ContainerPidAdjustmentTest fails on WSL (Bug - P4)

Reviewers

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/179/head:pull/179
$ git checkout pull/179

Update a local copy of the PR:
$ git checkout pull/179
$ git pull https://git.openjdk.org/crac.git pull/179/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 179

View PR using the GUI difftool:
$ git pr show -t 179

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/179.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@TimPushkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347430: [CRaC] ContainerPidAdjustmentTest fails on WSL

Co-authored-by: Timofei Pushkin <[email protected]>
Reviewed-by: rvansa

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the crac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rvansa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2025
@TimPushkin
Copy link
Collaborator Author

/contributor add tpushkin

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@TimPushkin
Contributor Timofei Pushkin <[email protected]> successfully added.

@TimPushkin
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@TimPushkin
Your change (at version bb13313) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Jan 10, 2025

Webrevs

@rvansa
Copy link
Collaborator

rvansa commented Jan 13, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

Going to push as commit 45afd38.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2025
@openjdk openjdk bot closed this Jan 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@rvansa @TimPushkin Pushed as commit 45afd38.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TimPushkin TimPushkin deleted the wsl-test branch January 13, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants