Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones #3039

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 12, 2024

I would like to fix this in 17.

Resolved Copyright, probably clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8300416 needs maintainer approval

Issue

  • JDK-8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3039/head:pull/3039
$ git checkout pull/3039

Update a local copy of the PR:
$ git checkout pull/3039
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3039

View PR using the GUI difftool:
$ git pr show -t 3039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3039.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e470734: 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows
  • ef8243a: 8331142: Add test for number of loader threads in BasicDirectoryModel
  • 41b4812: 8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2e2e71e1fa326b8d30f018a3e0726bbcd6d24019 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones Nov 12, 2024
@openjdk
Copy link

openjdk bot commented Nov 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Nov 12, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant