Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344589: Update IANA Language Subtag Registry to Version 2024-11-19 #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RadekCap
Copy link

@RadekCap RadekCap commented Jan 10, 2025

Backport of JDK-8344589 - Update IANA Language Subtag Registry to Version 2024-11-19

Clean backport.
Passed tier1 tests. There are the same failures as in that master branch:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg:tier1                     2579  2579     0     0   
>> jtreg:test/jdk:tier1                               2413  2392    21     0 <<
>> jtreg:test/langtools:tier1                         4543  4473    70     0 <<
   jtreg:test/jaxp:tier1                                 0     0     0     0   
   jtreg:test/lib-test:tier1                            33    33     0     0   
==============================
TEST FAILURE

Passed gtests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344589 needs maintainer approval

Issue

  • JDK-8344589: Update IANA Language Subtag Registry to Version 2024-11-19 (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/234/head:pull/234
$ git checkout pull/234

Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.org/jdk23u.git pull/234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 234

View PR using the GUI difftool:
$ git pr show -t 234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/234.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9267dfa63b1d6b3f339782d2b720055a3da8ae6a 8344589: Update IANA Language Subtag Registry to Version 2024-11-19 Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2025
@RadekCap
Copy link
Author

/approval request Update IANA Language Subtag Registry to Version 2024-11-19

@mlbridge
Copy link

mlbridge bot commented Jan 10, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@RadekCap
8344589: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant