8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java

[jankratochvil]

A clean backport.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8346713 needs maintainer approval

Issue

• JDK-8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.org/jdk24u.git pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/8.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 33561bf: 8346887: DrawFocusRect() may cause an assertion failure
• 0243349: 8346239: Improve memory efficiency of JimageDiffGenerator
• ca30621: 8346082: Output JVMTI agent information in hserr files
• e9109e8: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689
• 8c455fd: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE
• 3ce95da: 8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test
• 8135af1: 8346690: Shenandoah: Fix log message for end of GC usage report
• 79610be: 8346688: GenShen: Missing metadata trigger log message

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (4c857b15)

[RealCLanger]

Maybe you want to bring this change directly into jdk24 under RDP1 rule? It's a test only change...

[jankratochvil]

As this is P4 according to https://openjdk.org/jeps/3 RDP1 it should be dropped - I read it as delayed until backports for later update-releases.

[RealCLanger]

As this is P4 according to https://openjdk.org/jeps/3 RDP1 it should be dropped - I read it as delayed until backports for later update-releases.

No, in the table under the "Fix" column you find "P1–P5 doc/test changes" for RDP1. Only "real" P4 issues have to be dropped.

[jankratochvil]

So I have added jdk24u-fix-request to JDK-8346713.

[RealCLanger]

So I have added jdk24u-fix-request to JDK-8346713.

No, I was suggesting to backport it to jdk24.

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version 4c857b1) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 9c91ef4.
Since your change was applied there have been 8 commits pushed to the master branch:

• 33561bf: 8346887: DrawFocusRect() may cause an assertion failure
• 0243349: 8346239: Improve memory efficiency of JimageDiffGenerator
• ca30621: 8346082: Output JVMTI agent information in hserr files
• e9109e8: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689
• 8c455fd: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE
• 3ce95da: 8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test
• 8135af1: 8346690: Shenandoah: Fix log message for end of GC usage report
• 79610be: 8346688: GenShen: Missing metadata trigger log message

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @jankratochvil Pushed as commit 9c91ef4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.