-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaFX Incubator Modules #1617
base: master
Are you sure you want to change the base?
JavaFX Incubator Modules #1617
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
|
@kevinrushforth This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This PR contains a proposal for JavaFX Incubator Modules, along with an example incubator module might be implemented.
NOTE: This PR will remain in Draft and never be made
rfr
. It is intended only as supporting material for the proposal.Notes to Reviewers
The source branch of this PR is based on the source branch of PR #1616,
8309381-incubator
, which has the changes needed to support incubator modules. Click to see the diffs using that PR branch as the base.This PR includes the following:
jfx.incubator.myfeature
.This
jfx.incubator
branch is meant to be illustrative in nature. It will never be integrated, so the PR based on this branch will remain in Draft state as long as the PR is open (it will never becomerfr
).History
This supersedes an earlier Draft PR #1375
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1617/head:pull/1617
$ git checkout pull/1617
Update a local copy of the PR:
$ git checkout pull/1617
$ git pull https://git.openjdk.org/jfx.git pull/1617/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1617
View PR using the GUI difftool:
$ git pr show -t 1617
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1617.diff