Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8170720: VetoableListDecorator: Indexes to remove are not aggregated #1675

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mstr2
Copy link
Collaborator

@mstr2 mstr2 commented Jan 14, 2025

VetoableListDecorator does not correctly report removed indices. Instead of reporting ranges like [0, 3), it always reports a pairwise list of single removals like [0, 1, 1, 2, 2, 3).

The reason is a off-by-one error, and the fix is simple.

/reviewers 2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8170720: VetoableListDecorator: Indexes to remove are not aggregated (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1675/head:pull/1675
$ git checkout pull/1675

Update a local copy of the PR:
$ git checkout pull/1675
$ git pull https://git.openjdk.org/jfx.git pull/1675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1675

View PR using the GUI difftool:
$ git pr show -t 1675

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1675.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 14, 2025

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Ready for review label Jan 14, 2025
@openjdk
Copy link

openjdk bot commented Jan 14, 2025

@mstr2
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Jan 14, 2025

Webrevs

@kevinrushforth kevinrushforth self-requested a review January 14, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant