This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
8261705: Swing jtreg tests fail Metal API Validation with missing buffer binding #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hitting MTLRenderer_DrawScanLine with scanlineCount=0. So we end up calling drawPrimitives without actual vertex data. This is causing error when Metal API Validation is enabled. In OpenGL we have null checks for scanline data as well as scanlinecount. We need similar check in case of Metal.
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/lanai pull/191/head:pull/191
$ git checkout pull/191