This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
8261703: Many java/awt/ tests fail with Metal API Validation Stencil PixelFormat error #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LCD text rendering we get texture encoder which takes same shader parameters as LCD and then update its pipeline state locally and not in centralized MTLPaints. In cases where we use stencil based rendering and then move to LCD we will have invalid stencil state(Eventhough it doesnt change LCD text rendering output) because we override pipeline state locally after getting encoder. Moving LCD encoder state management to EncoderManager will resolve the issue when Metal API Validation is enabled.
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/lanai pull/194/head:pull/194
$ git checkout pull/194