8261891: sanity/client/SwingSet/src/EditorPaneDemoTest.java fails with Metal API Validation #201
Conversation
…h Metal API Validation Refactored AA shader usage. Performed end of AAshader encoder for incompatible rendering modes
|
👋 Welcome back avu! A progress list of the required criteria for merging this PR into |
|
@avu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
openjdk
bot
added
ready
|
/integrate |
openjdk
bot
added
integrated
| @@ -355,7 +366,8 @@ - (void)setContext:(MTLContex * _Nonnull)mtlc { | |||
| // | |||
| jboolean needEnd = JNI_FALSE; | |||
| if (_encoder != nil) { | |||
| if (_destination != dest || renderOptions->isAA != _encoderStates.aa) { | |||
| if (_destination != dest || renderOptions->isAA != _encoderStates.aa || | |||
| renderOptions->isAAShader != _encoderStates.aaShader) { | |||
There was a problem hiding this comment.
Hi Alexey,
Is there any performance impact because of ending the encoder on switch?
Thanks,
Jay
There was a problem hiding this comment.
Hi Jay,
Thanks for the comment. I didn’t find any difference at least with RenderPerfTest. However, looks like we don’t need to end the encoder here - the appropriate state will be recovered later in the code (by updatePipelineState method).
So, I’m going to remove this condition from the if statement.
Best Regards,
Alexey
There was a problem hiding this comment.
Hi Alexey,
Yes i also think we dont need to explicit end encoder here and leave it to updatePipelineState. This was the next clarification i wanted to ask.
Thanks,
Jay
Refactored AA shader usage. Performed end of AAshader encoder for incompatible rendering modes
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/lanai pull/201/head:pull/201$ git checkout pull/201