Fix Helm templating of the mutating/validating webhooks and namespaces #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
This PR basically fixes currently existing templating, doesn't change any defaults in
values.yaml
(but does apply some of them correctly now). See the changelog:https://github.com/vpedosyuk/openkruise-charts/blob/1b4abe91a1662df8a5d84540986eca1e2afbfd4c/versions/kruise/1.6.0/Chart.yaml#L22-L45
To get a better view on the changes I run:
I've successfully tested it with minikube and the default
values.yaml
:as well as with overriden values:
Additional changes:
ct lint
(fromscripts/lint.sh
) it failed due to the outdated configs so fixed some deprecated repo reference.ct lint
(fromscripts/lint.sh
) it failed due to the emptymaintainers
field so disabled this check as this particular field is actually empty for all versions of the chart.Checklist:
Changes are automatically published when merged to
master
. They are not published on branches.