Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helm templating of the mutating/validating webhooks and namespaces #91

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vpedosyuk
Copy link

Fixes:

  1. Dangerous MutatingWebhook for all "pod" resources that cannot be disabled in Helm values #90
  2. install kruise version 1.5.0 with helm,cant set webhookConfiguration.failurePolicy.pods=Ignore  #74
  3. maybe more

This PR basically fixes currently existing templating, doesn't change any defaults in values.yaml (but does apply some of them correctly now). See the changelog:
https://github.com/vpedosyuk/openkruise-charts/blob/1b4abe91a1662df8a5d84540986eca1e2afbfd4c/versions/kruise/1.6.0/Chart.yaml#L22-L45

To get a better view on the changes I run:

diff --recursive versions/kruise/1.5.2/ versions/kruise/1.6.0/

I've successfully tested it with minikube and the default values.yaml:

helm install kruise versions/kruise/1.6.0

as well as with overriden values:

installation:
  namespace: custom-ns
  createNamespace: true

featureGates: >-
  PodWebhook=false,
  KruiseDaemon=false

Additional changes:

  1. When I tried running ct lint (from scripts/lint.sh) it failed due to the outdated configs so fixed some deprecated repo reference.
  2. When I tried running ct lint (from scripts/lint.sh) it failed due to the empty maintainers field so disabled this check as this particular field is actually empty for all versions of the chart.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to master. They are not published on branches.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @vpedosyuk! It looks like this is your first PR to openkruise/charts 🎉

@kruise-bot
Copy link

@vpedosyuk: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants