-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch rollout-batch-id even without rollout-id in workload #248
Patch rollout-batch-id even without rollout-id in workload #248
Conversation
a702034
to
84a0e60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 45.55% 44.95% -0.60%
==========================================
Files 57 61 +4
Lines 6395 7002 +607
==========================================
+ Hits 2913 3148 +235
- Misses 2989 3309 +320
- Partials 493 545 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
84a0e60
to
eb69d8d
Compare
simply use revision id may not works for rollback cases, rollback also support mutli-batch rollback. |
can you give me a specific scenario so I can reproduce it? maybe can use the SafeEncodeString func to encode the revision id. |
maybe we can add a prefix e.g. "rollback-" to the canary revision id, so we can distinguish the pod that is not updated in previous rollout with the pod that is rollbacked. we can tell whether the rollout is a rollback using the workload.IsInRollback |
40074d3
to
a298ef2
Compare
a298ef2
to
abc4fc2
Compare
Signed-off-by: zhihao jian <[email protected]> add rollback prefix to identify in rollback pods fix patch rollout id fix test fix add prefix when rollout id is empty fix test
abc4fc2
to
3ed3832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
#244
Ⅲ. Special notes for reviews