Skip to content

Commit

Permalink
fix: billing dependency cleanup
Browse files Browse the repository at this point in the history
The stripe app service is not required by billing, as it accesses it
using the app's registry.

The stripe app will need to access billing to trigger actions based on the
webhooks, thus we are eliminating a circular dependency.
  • Loading branch information
turip committed Jan 31, 2025
1 parent 064237e commit 384ac85
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 31 deletions.
2 changes: 0 additions & 2 deletions app/common/billing.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (

"github.com/openmeterio/openmeter/app/config"
"github.com/openmeterio/openmeter/openmeter/app"
appstripe "github.com/openmeterio/openmeter/openmeter/app/stripe"
"github.com/openmeterio/openmeter/openmeter/billing"
billingadapter "github.com/openmeterio/openmeter/openmeter/billing/adapter"
billingservice "github.com/openmeterio/openmeter/openmeter/billing/service"
Expand Down Expand Up @@ -41,7 +40,6 @@ func BillingService(
logger *slog.Logger,
db *entdb.Client,
appService app.Service,
appStripeService appstripe.Service,
billingAdapter billing.Adapter,
billingConfig config.BillingConfiguration,
customerService customer.Service,
Expand Down
56 changes: 29 additions & 27 deletions cmd/billing-worker/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cmd/jobs/internal/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cmd/server/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 384ac85

Please sign in to comment.