fix: split lines should not be returned for gathering invoices #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turip
force-pushed
the
feature/om-1072-split-lines-should-not-be-returned-for-gathering-invoices
branch
from
44f0335 to
94720fe
Compare
turip
changed the base branch from
feature/om-1094-list-invoices-shows-deleted-invoices
to
main
turip
force-pushed
the
feature/om-1072-split-lines-should-not-be-returned-for-gathering-invoices
branch
from
94720fe to
4e7243e
Compare
Right now we have a sugar on gathering invoices that calculates the totals, for that we fetch all the lines regardless of the expand settings. This patch ensures that we are emulating the expand settings in terms of lines so that we are not returning extra data.
turip
force-pushed
the
feature/om-1072-split-lines-should-not-be-returned-for-gathering-invoices
branch
from
4e7243e to
f370b99
Compare
tothandras
approved these changes
Jan 21, 2025
turip
deleted the
feature/om-1072-split-lines-should-not-be-returned-for-gathering-invoices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Right now we have a sugar on gathering invoices that calculates the totals, for that we fetch all the lines regardless of the expand settings.
This patch ensures that we are emulating the expand settings in terms of lines so that we are not returning extra data.