Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static code analysis service provided by SonarCloud.io #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mwever
Copy link
Contributor

@mwever mwever commented Aug 5, 2019

Summary:
In this pull request the sonarqube plugin is added to the maven build. Moreover, the continuous integration is configured to automatically run code quality analyses via sonarcloud.io and provide summaries about the code quality and test coverage. From now on, the code quality of a branch is always compared to its parent. In this way, we can require new code not to worsen the quality of the code base and thus define a quality gate for allowing the merge of a pull request.

Expected positive effects:

  • Integration of the code quality analysis into the CI
  • Enabling quality gates for merging pull requests

Expected negative effects:

  • None

@mwever
Copy link
Contributor Author

mwever commented Aug 5, 2019

The build failed due to some junit tests, is there any known issue with this connection timeout problem? When I run these tests locally there is no issue with these particular tests and also the previous 3 builds on this branch went through?

Base automatically changed from develop to fix/issue_44 March 19, 2021 09:53
Base automatically changed from fix/issue_44 to master March 19, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant