Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kwargs through task to get_dataset #1345

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Conversation

knyazer
Copy link
Contributor

@knyazer knyazer commented Aug 23, 2024

Allows to follow the directions in the FutureWarning Starting from Version 0.15 `download_data`, `download_qualities`, and `download_features_meta_data` will all be ``False`` instead of ``True`` by default to enable lazy loading.

Reference Issue

None

What does this PR implement/fix? Explain your changes.

When doing something like

dataset = task.get_dataset()

which takes no parameters one gets the warning. Now it takes any parameters that the datasets.get_dataset takes, thus allowing to set the optional parameters.

How should this PR be tested?

Test that the suite passes, I guess; there is not really a short way to test.

Any other comments?

Maybe kwargs-passing behaviour should be added to all the other methods in the OpenMLTask?

(this PR might be noise again, though I checked that the issue is present on dev, sorry if I am wrong though)

Allows to follow the directions in the warning ```Starting from Version 0.15 `download_data`, `download_qualities`, and `download_features_meta_data` will all be ``False`` instead of ``True`` by default to enable lazy loading.```
Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I think it's fair to allow this, but it needs a small improvement for the documentation. I don't think it is necessary to add tests for this functionality.

openml/tasks/task.py Show resolved Hide resolved
@knyazer
Copy link
Contributor Author

knyazer commented Sep 16, 2024

Btw, are you in need of any maintainers/collaborators? I'm happy to be spending quite a bit of time supporting openml, since I work on automl, and frequently use the library, and I have a bit of free time this year (part-time job, so I can work on random projects quite a bit).

And yeah, it seems like there are a lot of low-ish priority feature requests in the issues, and you are effectively the only maintainer..

So yeah, if you are happy with that I can just start implementing/fixing random stuff pretty actively 😉

@PGijsbers
Copy link
Collaborator

Absolutely! It would be best if you could join our Slack server (see https://openml.org/about) for general contact and maybe discussing the kind of issues we currently prioritize. For discussing specific issues/prs, GitHub is the main platform. We also do monthly engineering calls that are open. Every first monday of the month at 17.00 CEST (when daylight saving is applicable in Europe, otherwise CET).
We always appreciate the help!

openml/tasks/task.py Outdated Show resolved Hide resolved
Remove Py3.8+ feature for backwards compatibility
@knyazer
Copy link
Contributor Author

knyazer commented Sep 18, 2024

Alright, disallowing positional arguments while there are zero of them is useless; I just put slash there to be more explicit, as a sort of self-documentation :)

@knyazer
Copy link
Contributor Author

knyazer commented Sep 18, 2024

And yeah, thanks for fixing it, the back and forth through the GitHub is a lot slower than changing two chars in the commit

@PGijsbers PGijsbers merged commit d37542b into openml:develop Sep 29, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants