New notification provider...and small change？ #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: . Add Dingtalk notification . Add Feishu notification Test: . Download notifications with file names - Xunlei Download provider only. - Support notifications: Slack. Dingtalk.Feishu
❌ Deploy Preview for kubespider failed.
|
|
受限于测试环境，仅测试飞书，能正常通知，但有报错信息 |
嗯。这个后面我顺手看了下日志，报错我也看到了。。实际上迅雷任务是添加了，通知也通知了。。原来改后没错误提示，我到时再去看看 |
3个都修了，当时复制粘贴的。没注意改下面的response = =
|
|
看了看，应该没什么问题，我用alist测试磁力链接是可以正常推送的 麻烦大佬修一下ci里面的检查，然后把README稍微改改 |
过两天我一起改一下，先放这一会。因为我发现。有个地方ed2k里面没写完。。我忘了当时是没写还是怎么的。。倒也简单 |
这部分我comment了，顺便把review里面其他comment都resovle一下 |
我简单修了修。还没修完。估计有些还是过不了pylint。不过我部署在我docker上用了几天倒没啥问题。。最近要过年了，假酒喝太多。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:
. Add Dingtalk notification
. Add Feishu notification
Test:
. Download notifications with file names
1、添加了钉钉，飞书通知
2、魔改了下，在迅雷下载的时候，我把磁力链接（怎么做的真忘了。。时间太久，看了下都是7个月之前了，我自己用了很久没啥问题），就是之前磁力，种子啥的推送没有名字，只有个链接，经常我同学远程一推，我都不知道下的啥电影 - -，改后。钉钉。飞书。推送的时候就会有个，磁力或种子的名称。
xunlei_download_provider/provider.py，添加了138-145行，模块在utils/magnet_url.py
/core/webhook_server.py。改动在85-94行
在钉钉和飞书的代码中就能看见有个self.magnet_name
应该不影响其他软件的。2个新通知的 self.magnet_name 都有初始化空值。至于能不能正常推送，我迅雷是可以，就靠你们测试下吧。
slack改后的（未提交上来，因为 json 结构变动略大了，结构都不一样了，我就自己使用去了）
主要是工作要求国产手机，结果Slack靠google FCM推送，国产安卓FCM一言难尽。。所以新增两个通知。我干脆就一次性把所有的都提交上来，就没有分2次提交