Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lock) exptime can be set per key #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(lock) exptime can be set per key #10

wants to merge 1 commit into from

Conversation

subnetmarco
Copy link

Closes #7.

@subnetmarco
Copy link
Author

@agentzh any comments on this PR?

@agentzh
Copy link
Member

agentzh commented Oct 16, 2016

I think it's a bit confusing to use the two words "timeout" and "exptime" in the same API since they are essentially the same thing in this context. I think you are actually proposing a per-key timeout value here, right? Then we can just accept a "timeout" argument in lock() to simply override the object-level default timeout setting. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subnetmarco @agentzh