Skip to content

Commit

Permalink
Venue: fix get content value if not present (#2114)
Browse files Browse the repository at this point in the history
* fix get content value if not present

* increase version

* add missing number property
  • Loading branch information
melisabok authored Apr 26, 2024
1 parent 87b9d51 commit bab90f6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions openreview/journal/webfield/actionEditorWebfield.js
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,8 @@ var renderData = function(venueStatusData) {
id: row.submission.forum,
noteId: row.submission.forum,
invitationId: Webfield2.utils.getInvitationId(VENUE_ID, row.submission.number, REVIEW_NAME, { submissionGroupName: SUBMISSION_GROUP_NAME })
})
}),
number: row.submission.number
}
});
}
Expand All @@ -564,7 +565,8 @@ var renderData = function(venueStatusData) {
id: row.submission.forum,
noteId: row.submission.forum,
invitationId: Webfield2.utils.getInvitationId(VENUE_ID, row.submission.number, OFFICIAL_RECOMMENDATION_NAME, { submissionGroupName: SUBMISSION_GROUP_NAME })
})
}),
number: row.submission.number
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion openreview/venue/process/assignment_post_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def process_update(client, edge, invitation, existing_edge):
reviewers_id = invitation.content['reviewers_id']['value']
sync_sac_id = invitation.content.get('sync_sac_id',{}).get('value')
sac_assignment_id = invitation.content.get('sac_assignment_id',{}).get('value')
sender = domain.content.get('message_sender').get('value')
sender = domain.get_content_value('message_sender')
pretty_name = openreview.tools.pretty_id(reviewers_name)
pretty_name = pretty_name[:-1] if pretty_name.endswith('s') else pretty_name

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
setup(
name='openreview-py',

version='1.39.2',
version='1.39.3',

description='OpenReview API Python client library',
url='https://github.com/openreview/openreview-py',
Expand Down

0 comments on commit bab90f6

Please sign in to comment.