fix short name issue in email template (#1427)

openreview · Oct 19, 2022 · e01ba4a · e01ba4a
1 parent 3171073
commit e01ba4a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/openreview/conference/invitation.py b/openreview/conference/invitation.py
@@ -46,6 +46,7 @@ def __init__(self, conference, under_submission):
 
                 if submission_stage.submission_email:
                     email_template = submission_stage.submission_email
+                    email_template = email_template.replace('{{Abbreviated_Venue_Name}}', conference.get_short_name())
                     email_template = email_template.replace('{{action}}', '{action}')
                     email_template = email_template.replace('{{note_title}}', '{note.content[\'title\']}')
                     email_template = email_template.replace('{{note_abstract}}', '{note_abstract}')

diff --git a/openreview/venue_request/venue_request.py b/openreview/venue_request/venue_request.py
@@ -33,7 +33,7 @@ def setup_venue_revision(self):
         revision_content['submission_email'] = {
             'order': 20,
             'description': 'Please review the email sent to authors when a submission is posted. Make sure not to remove the parenthesized tokens.',
-            'default': f'''Your submission to ${self.venue_request.request_content['Abbreviated Venue Name']} has been {{action}}.\n\nSubmission Number: {{note_number}} \n\nTitle: {{note_title}} {{note_abstract}} \n\nTo view your submission, click here: https://openreview.net/forum?id={{note_forum}}''',
+            'default': '''Your submission to {{Abbreviated_Venue_Name}} has been {{action}}.\n\nSubmission Number: {{note_number}} \n\nTitle: {{note_title}} {{note_abstract}} \n\nTo view your submission, click here: https://openreview.net/forum?id={{note_forum}}''',
             'value-regex':'[\\S\\s]{1,10000}',
             'hidden': True
         }

diff --git a/tests/test_venue_request.py b/tests/test_venue_request.py
@@ -427,7 +427,7 @@ def test_venue_revision(self, client, test_client, selenium, request_page, venue
                         'value-regex': '.*'
                     }
                 },
-                'submission_email': 'Your submission to TestVenue@OR\'2030 has been {{action}}.\n\nSubmission Number: {{note_number}}\n\nTitle: {{note_title}} {{note_abstract}}\n\nTo view your submission, click here: https://openreview.net/forum?id={{note_forum}}\n\nThis is some extra information to be added at the end of the email template.',
+                'submission_email': 'Your submission to {{Abbreviated_Venue_Name}} has been {{action}}.\n\nSubmission Number: {{note_number}}\n\nTitle: {{note_title}} {{note_abstract}}\n\nTo view your submission, click here: https://openreview.net/forum?id={{note_forum}}\n\nThis is some extra information to be added at the end of the email template.',
                 'reviewer_roles': ['Reviewers', 'Expert_Reviewers']
             },
             forum=venue['request_form_note'].forum,
@@ -930,6 +930,7 @@ def test_venue_matching_setup(self, client, test_client, selenium, request_page,
         assert messages and len(messages) == 1
         assert 'This is some extra information to be added at the end of the email template.' in messages[0]['content']['text']
         assert 'Title: test submission' in messages[0]['content']['text']
+        assert 'Your submission to TestVenue@OR\'2030 has been posted.'
 
         messages = client.get_messages(subject='{} has received a new submission titled {}'.format(venue['request_form_note'].content['Abbreviated Venue Name'], submission.content['title']))
         assert messages and len(messages) == 3