Add recipe for Spring Boot 3.4 migration #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
...tWithSpringBoot_3_4/java/org/openrewrite/java/spring/boot3/SpringBootVersionUpgradeTest.java
Outdated
Show resolved
Hide resolved
…ot3/SpringBootVersionUpgradeTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
changed the title
Laurens-W
reviewed
Nov 18, 2024
...tWithSpringBoot_3_4/java/org/openrewrite/java/spring/boot3/SpringBootVersionUpgradeTest.java
Outdated
Show resolved
Hide resolved
Laurens-W
reviewed
Nov 18, 2024
...tWithSpringBoot_3_4/java/org/openrewrite/java/spring/boot3/SpringBootVersionUpgradeTest.java
Outdated
Show resolved
Hide resolved
Laurens-W
reviewed
Nov 18, 2024
timtebeek
approved these changes
Nov 18, 2024
|
When will this recipe be available via maven central? I would like to use it. |
|
hi! Right now this recipe doesn't do anything just yet; it merely bumps the dependencies. We're looking to include the steps needed for Spring Framework 6.2 ( #627 ) as well as changes needed for Spring Boot 3.4 before we recommend running that migration through OpenRewrite. We wouldn't want you to have a bad experience with a partial recipe. Help always welcome to fill in the gaps with regards to recipe coverage. |
|
@timtebeek thanks for the reply! Just saw that commit :) |
sambsnyd
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Add recipe for springboot 3.4 migration * Add test * Fix comment * Fix test * Update src/testWithSpringBoot_3_4/java/org/openrewrite/java/spring/boot3/SpringBootVersionUpgradeTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Drop expected cycles that made changes * Expect 3.3 before 3.4 is released --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tim te Beek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Two changes
What's your motivation?
Anything in particular you'd like reviewers to focus on?
org.openrewrite.java.spring.boot3.SpringBoot3BestPracticesrecipe, as was the case with the 3.3 upgrade. However, since the recipe is now extracted/standalone do we still want this to be the case?Anyone you would like to review specifically?
@Laurens-W @timtebeek
Any additional context
Checklist