Replace NavigableMap<LineColumn, List<ASTNode>> to NavigableMap<LineColumn, ASTNode>, because it's impossible to have multiple elements at the very same line and column
#4986
+40
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neColumn, ASTNode>`, because it's impossible to have multiple elements at the very same line and column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Little code refactoring; so no new features or bug fixes.
What's your motivation?
When I worked on #4068, I looked at the
line.
After thinking about it, I wondered how for any key there can be multiple nodes attached to it. Since the key is an object of line number and column (basically the x and y of the source code), there is absolutely no way multiple elements can be found, unless I am very much mistaken.
Thus I replaced the list in favour of one ASTNode object.