Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate ANTLR sources and rewriteRun #5006

Closed
wants to merge 1 commit into from

Conversation

greg-at-moderne
Copy link
Contributor

Not planning to merge. Just checking what current rewrite/licenseFormat combo we apply now.

@greg-at-moderne greg-at-moderne self-assigned this Feb 10, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-hcl/src/main/java/org/openrewrite/hcl/format/TabsAndIndentsVisitor.java
    • lines 255-256
  • rewrite-hcl/src/main/java/org/openrewrite/hcl/internal/HclPrinter.java
    • lines 363-364
  • rewrite-java/src/main/java/org/openrewrite/java/internal/template/AnnotationTemplateGenerator.java
    • lines 158-159
  • rewrite-java/src/main/java/org/openrewrite/java/internal/template/BlockStatementTemplateGenerator.java
    • lines 281-282
    • lines 669-669
  • rewrite-java/src/main/java/org/openrewrite/java/search/FindEmptyClasses.java
    • lines 57-57
  • rewrite-xml/src/main/java/org/openrewrite/xml/internal/XmlPrinter.java
    • lines 106-106
  • rewrite-yaml/src/main/java/org/openrewrite/yaml/cleanup/RemoveUnusedVisitor.java
    • lines 76-76

Comment on lines +131 to +132
private Stack<CurlyType> leftCurlyStack = new Stack<CurlyType>();
private Stack<String> heredocIdentifier = new Stack<String>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private Stack<CurlyType> leftCurlyStack = new Stack<CurlyType>();
private Stack<String> heredocIdentifier = new Stack<String>();
private Stack<CurlyType> leftCurlyStack = new Stack<>();
private Stack<String> heredocIdentifier = new Stack<>();

@@ -3323,8 +3323,7 @@ public final TemplateInterpolationContext templateInterpolation() throws Recogni
return _localctx;
}

@Override
public boolean sempred(RuleContext _localctx, int ruleIndex, int predIndex) {
public boolean sempred(RuleContext _localctx, int ruleIndex, int predIndex) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public boolean sempred(RuleContext _localctx, int ruleIndex, int predIndex) {
@Override
public boolean sempred(RuleContext _localctx, int ruleIndex, int predIndex) {

@@ -1505,8 +1505,7 @@ public final IndexesContext indexes() throws RecognitionException {
return _localctx;
}

@Override
public boolean sempred(RuleContext _localctx, int ruleIndex, int predIndex) {
public boolean sempred(RuleContext _localctx, int ruleIndex, int predIndex) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public boolean sempred(RuleContext _localctx, int ruleIndex, int predIndex) {
@Override
public boolean sempred(RuleContext _localctx, int ruleIndex, int predIndex) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant