Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-release Lombok runtime dependency #5013

Merged
merged 13 commits into from
Feb 12, 2025
Merged

Use pre-release Lombok runtime dependency #5013

merged 13 commits into from
Feb 12, 2025

Conversation

knutwannheden
Copy link
Contributor

@knutwannheden knutwannheden commented Feb 11, 2025

Changes the Gradle dependencies so that a custom 1.18.37 pre-release of Lombok is used at runtime (published as org.openrewrite.tools:lombok). This is required to get Lombok working in OpenRewrite.

rewrite-java-lombok/build.gradle.kts Outdated Show resolved Hide resolved
rewrite-java-lombok/build.gradle.kts Outdated Show resolved Hide resolved
rewrite-java/build.gradle.kts Outdated Show resolved Hide resolved
@knutwannheden knutwannheden changed the title Try to fix Lombok setup Use correct Lombok runtime dependency Feb 11, 2025
@knutwannheden knutwannheden marked this pull request as draft February 11, 2025 15:52
@knutwannheden
Copy link
Contributor Author

While this appears to work for local builds it won't work in the context of build plugins, as that local lombok.jar won't be on the classpath then.

@knutwannheden knutwannheden changed the title Use correct Lombok runtime dependency Use pre-release Lombok runtime dependency Feb 12, 2025
@knutwannheden knutwannheden marked this pull request as ready for review February 12, 2025 10:12
@knutwannheden knutwannheden merged commit 83b6001 into main Feb 12, 2025
1 of 2 checks passed
@knutwannheden knutwannheden deleted the lombok-fix-2 branch February 12, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants