Fix CI again #745
Merged
Fix CI again #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodearnest
force-pushed
the
fix-ci2
branch
from
22af96f
to
6cc8b0a
Compare
bloodearnest
force-pushed
the
fix-ci2
branch
5 times, most recently
from
e215cf7
to
75a6eb1
Compare
madwort
reviewed
Sep 30, 2024
bloodearnest
force-pushed
the
fix-ci2
branch
from
25278b2
to
b4092bf
Compare
This was prompted by a bug in setup-python@v5, which means that the post-clean-up job will fail if you do not actually install anything in pip, as the cache directory will not be created. This has hit a few of our GHA workflows. actions/setup-python#815 The reason this was triggering for job-runner was that the current CI setup was pretty much broken. Firstly, the PYTHON_VERSION env var was not being set, which meant that every test run was always testing 3.8, not 3.9 or 3.10 as per the matrix. Fixing this meant a bit of windows/powershell finesse. It always explains the fact that for some reason, even though we have 22.04 in the matrix, we did not run the tests on it (this was what triggered the above failure). Additionally, we were going to the trouble of installing/starting docker on macos, and then not even running the docker tests. This feels like we had the abandonded attempts of getting docker tests running on macos. To fix this, I just removed those steps and fully embraced not running docker tests (which required excluding a few more tests). Additionally, macos-12 is old, and has very slow runners, so I took the opportunity to update to using macos-13. I did attempt to use our opensafely-core/setup-action, but it still seems to have problems with just on windows, and my yak stack was full.
bloodearnest
force-pushed
the
fix-ci2
branch
from
db03e08
to
1df7f2b
Compare
madwort
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was prompted by a bug in setup-python@v5, which means that the
post-clean-up job will fail if you do not actually install anything in
pip, as the cache directory will not be created. This has hit a few of
our GHA workflows.
actions/setup-python#815
The reason this was triggering for job-runner was that the current CI
setup was pretty much broken.
Firstly, the PYTHON_VERSION env var was not being set, which meant that
every test run was always testing 3.8, not 3.9 or 3.10 as per the
matrix. Fixing this meant a bit of windows/powershell finesse. It
always explains the fact that for some reason, even though we have 22.04
in the matrix, we did not run the tests on it (this was what triggered
the above failure).
Additionally, we were going to the trouble of installing/starting docker
on macos, and then not even running the docker tests. This feels like we
had the abandonded attempts of getting docker tests running on macos.
To fix this, I just removed those steps and fully embraced not running
docker tests (which required excluding a few more tests). Additionally,
macos-12 is old, and has very slow runners, so I took the opportunity to
update to using macos-13.
I did attempt to use our opensafely-core/setup-action, but it still
seems to have problems with just on windows, and my yak stack was full.