Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): use official rollup typescript plugin #101

Closed
wants to merge 1 commit into from
Closed

chore(deps): use official rollup typescript plugin #101

wants to merge 1 commit into from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Dec 31, 2024

Changes

  • use official rollup typescript plugin
  • typescript is optional peer and should be explicit dependency

Reference

Closes #99 .

@Rotzbua
chore(deps): use official rollup typescript plugin
46c10b0 
* `typescript` is optional peer and should be explicit dependency
@ochafik ochafik mentioned this pull request Dec 31, 2024
Merged
@ochafik
Copy link
Collaborator

ochafik commented Dec 31, 2024

Hey @Rotzbua,

I decided to ditch rollup altogether in #102 and use webpack for both the main binary and the worker (much improved debuggability!), so will close this, but thanks for splitting this out! (and for the other PRs :-))

@ochafik ochafik closed this Dec 31, 2024
@Rotzbua Rotzbua deleted the chore_typescript branch January 1, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple plugins for typescript
2 participants
@Rotzbua @ochafik