decode stdout/stderr from run_command (SOFTWARE-5451) #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default Popen.communicate() returns bytes objects, which are printed in a few places - and show up in the logs as b'...', which is especially annoying due to all the escaped internal newlines.
@matyasselmeci - would you prefer
encoding="latin1"
or anything? I think that would make the prints print garbage if there is actual utf8 data in stdout/stderr, though I know sometimes you like to guard against stray bits.