Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] add more osd namespacing #9358

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

angle943
Copy link
Contributor

@angle943 angle943 commented Feb 8, 2025

Description

  • add more namespaced custom commands to make neo and main in sync:

BREAKING CHANGES:

cy.navigateToWorkSpaceHomePage -> cy.osd.navigateToWorkSpaceHomePage
cy.navigateToWorkSpaceSpecificPage -> cy.osd.navigateToWorkSpaceSpecificPage
cy.waitForLoader -> cy.osd.waitForLoader

cy.updateSaveQuery -> cy.osd.updateSavedQuery
cy.loadSaveQuery -> cy.osd.loadSavedQuery
cy.clearSaveQuery -> cy.clearSavedQuery
cy.deleteSaveQuery -> cy.deleteSavedQuery

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Justin Kim <[email protected]>
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (6cf56f0) to head (3f03b33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9358   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files        3817     3817           
  Lines       91862    91862           
  Branches    14552    14552           
=======================================
  Hits        56697    56697           
  Misses      31509    31509           
  Partials     3656     3656           
Flag Coverage Δ
Linux_1 29.00% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.19% <ø> (-0.01%) ⬇️
Linux_4 28.90% <ø> (ø)
Windows_1 29.01% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Kim <[email protected]>
@angle943 angle943 marked this pull request as draft February 12, 2025 22:34
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants